New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested agg needs to reset root doc between segments. #9441

Merged
merged 1 commit into from Jan 27, 2015

Conversation

Projects
None yet
3 participants
@martijnvg
Member

martijnvg commented Jan 27, 2015

PR for #9437 and #9436

This bug was found by the CI which was caused by yesterday's changes to nested aggregator. This isn't a bug in a released version.

@jpountz

This comment has been minimized.

Contributor

jpountz commented Jan 27, 2015

LGTM

This stuff is tricky... Thanks for adding unit tests, we definitely need more of these with aggs...

@martijnvg martijnvg merged commit d1e5368 into elastic:1.x Jan 27, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@martijnvg martijnvg deleted the martijnvg:aggs/nested/reset_root_doc branch May 18, 2015

@clintongormley clintongormley changed the title from Aggs: nested agg needs to reset root doc between segments. to Nested agg needs to reset root doc between segments. Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment