Remove all blocking on Listenable*Future #94411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are almost no places where we block a thread to wait on the result of a `ListenableFuture` or `ListenableActionFuture`, and the few places that do so can trivially use a `PlainActionFuture` instead. This commit removes all blocking on `ListenableFuture` or `ListenableActionFuture`. Relates elastic#94386
DaveCTurner
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
saarikabhasi
pushed a commit
to saarikabhasi/elasticsearch
that referenced
this pull request
Apr 10, 2023
There are almost no places where we block a thread to wait on the result of a `ListenableFuture` or `ListenableActionFuture`, and the few places that do so can trivially use a `PlainActionFuture` instead. This commit removes all blocking on `ListenableFuture` or `ListenableActionFuture`. Relates elastic#94386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are almost no places where we block a thread to wait on the result of a
ListenableFutureorListenableActionFuture, and the few places that do so can trivially use aPlainActionFutureinstead. This commit removes all blocking onListenableFutureorListenableActionFuture.Relates #94386