Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FsInfo device deduplication #94744

Merged
merged 9 commits into from
Mar 27, 2023
Merged

Fix FsInfo device deduplication #94744

merged 9 commits into from
Mar 27, 2023

Commits on Mar 24, 2023

  1. Add a failing test

    @joegallo
    joegallo committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    bc96979 View commit details
    Browse the repository at this point in the history

  2. De-duplicate on mount rather than path

    @joegallo
    joegallo committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    607fd4d View commit details
    Browse the repository at this point in the history

  3. Update docs/changelog/94744.yaml

    @joegallo
    joegallo committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    3442448 View commit details
    Browse the repository at this point in the history

  4. Remove reference to 'and spins' 

    That code for spins hasn't existed in years.
    @joegallo
    joegallo committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    966f660 View commit details
    Browse the repository at this point in the history

  5. Tweak a comment, add a comment

    @joegallo
    joegallo committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    7f862c6 View commit details
    Browse the repository at this point in the history

  6. Drop @nullable from mount and type 

    They're not especially nullable as compared to, say, path. All of them
can be null in the case of an FsInfo.Path that represents a total
rather than a concrete entry. Any of them can be null in tests.
    @joegallo
    joegallo committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    a815d7d View commit details
    Browse the repository at this point in the history

  7. Tweak and add comments and examples

    @joegallo
    joegallo committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    d74fdce View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into fix-fs-info-device-deduplication

    @joegallo
    joegallo committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    cc1fed7 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Merge branch 'main' into fix-fs-info-device-deduplication

    @joegallo
    joegallo committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    925a9bb View commit details
    Browse the repository at this point in the history