Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs logging configuration: removed dead link and added javadoc reference instead. #95080

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

alstolten
Copy link
Member

Removed a link pointing nowhere and added javadoc reference instead.

@alstolten alstolten added >docs General docs changes Team:Docs Meta label for docs team labels Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added v8.8.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 6, 2023
@abdonpijpelink abdonpijpelink added auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.7.1 labels Apr 6, 2023
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've left a small suggestion (we prefer "refer to" over "see" in the docs)

docs/reference/setup/logging-config.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
@abdonpijpelink
Copy link
Contributor

@elasticmachine test this please

@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.7

alstolten added a commit to alstolten/elasticsearch that referenced this pull request Apr 12, 2023
…ence instead. (elastic#95080)

* docs: removed dead link and added javadoc reference instead.

* Update docs/reference/setup/logging-config.asciidoc

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>

---------

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Apr 12, 2023
…ence instead. (#95080) (#95173)

* docs: removed dead link and added javadoc reference instead.

* Update docs/reference/setup/logging-config.asciidoc



---------

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.7.1 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants