Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Include model definition install status for Pytorch models #95271

Merged
merged 7 commits into from
Apr 17, 2023

Conversation

davidkyle
Copy link
Member

@davidkyle davidkyle commented Apr 17, 2023

Add a new include flag definition_status to the GET trained models API.

GET _ml/trained_models/<MODEL_ID>?include=definition_status

When the flag is present the trained model configuration returned in the response will have the new boolean field fully_defined if the full model definition is present.

The API is not compatible with wildcards or multiple model Ids. model_id must map to a single model with model_type == PYTORCH

@github-actions
Copy link

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Apr 17, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

Hi @davidkyle, I've created a changelog YAML for you.

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you could just fix the incomplete sentence in the docs before merging.

@davidkyle
Copy link
Member Author

I wasn't happy with is_fully_downloaded as some models are uploaded.

I've changed the request parameter from download_status -> definition_status
And the body response from is_fully_downloaded -> fully_defined

@davidkyle
Copy link
Member Author

@elasticmachine update branch

@davidkyle davidkyle merged commit 6de8469 into elastic:main Apr 17, 2023
@davidkyle davidkyle deleted the downloaded-status branch April 17, 2023 17:12
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Apr 18, 2023
…tic#95271)

Adds a new include flag definition_status to the GET trained models API.
When present the trained model configuration returned in the response 
will have the new boolean field fully_defined if the full model definition 
is exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :ml Machine learning Team:ML Meta label for the ML team v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants