Introduce the index.lifecycle.prefer_ilm setting #95423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces an index setting that'll allow to switch the preference for the system that manages a data stream backing index. This setting defaults to `true` (preferring ILM when both ILM and DLM are applicable for an index). Note that the prefer_ilm setting will only express a preference, it'll not enforce the presence of a particular management service e.g. if an index has `prefer_ilm: false` and an ILM policy configured, but no DLM configuration, the index will be managed by ILM (despite the preference for DLM)
19 tasks
|
Hi @andreidan, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
andreidan
commented
Apr 20, 2023
...plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/TransportResumeFollowAction.java
Outdated
Show resolved
Hide resolved
dakrone
approved these changes
Apr 21, 2023
...plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/TransportResumeFollowAction.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
gmarouli
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Thank you for adding this flag @andreidan . LGTM, I have one minor comment, (apologies if they are there and I missed them) I was thinking it would be nice to a couple of tests also from DLM to ILM, if it's a path we support it should be tests. It can also come from a subsequent PR.
server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
Outdated
Show resolved
Hide resolved
|
@gmarouli Thanks for the review
That's a great shout, I'll add them in a follow up PR if that's ok (this PR is quite big already) |
|
@elasticmachine update branch |
|
Opened #95524 @elasticmachine run elasticsearch-ci/part-2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an index setting that'll allow to switch the preference for the system that manages a data stream backing index. This setting defaults to
true(preferring ILM when both ILM and DLM are applicable for an index).Note that the prefer_ilm setting will only express a preference, it'll not enforce the presence of a particular management service e.g. if an index has
prefer_ilm: falseand an ILM policy configured, but no DLM configuration, the index will be managed by ILM (despite the preference for DLM)Note that documentation for the setting will be done in a subsequent PR.
There will also be subsequent work to improve the
GET _data_streamAPI to better indicate which system manages each backing index.Relates to #93596