Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behavioral Analytics] Use a a client with ent-search origin in the BulkProcessorFactory. #95614

Conversation

afoucret
Copy link
Contributor

Fix a bug when using an API Key with only the post_behavioral_analytics_event cluster privilege.
The event is accepted but never ingested to the data stream.
This is caused by a wrong instantiation of the client used by the bulk processor.

More context here: post_behavioral_analytics_event

@afoucret afoucret added >bug v8.8.0 :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team labels Apr 27, 2023
@elasticsearchmachine elasticsearchmachine added v8.9.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 27, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @afoucret, I've created a changelog YAML for you.

Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@afoucret afoucret merged commit df5d27a into elastic:main Apr 27, 2023
@afoucret afoucret added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label Apr 27, 2023
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me. Since it was discovered with manual testing we need an explicit test though. Security is enabled on all our rest tests so we should be able to verify that the event is indexed after the posting ?

@afoucret
Copy link
Contributor Author

@jimczi I plan to add some end to end tests to cover those

@afoucret
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.8

Questions ?

Please refer to the Backport tool documentation

afoucret added a commit to afoucret/elasticsearch that referenced this pull request Apr 27, 2023
afoucret added a commit that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >bug :EnterpriseSearch/Application Enterprise Search external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Enterprise Search Meta label for Enterprise Search team v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants