Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand start and end time to nanoseconds during coordinator rewrite when needed #96035

Merged

Conversation

martijnvg
Copy link
Member

Expand index.time_series.start_time and end_time to nanoseconds if timestamp field's resolution is set to nanoseconds. When creating coordinator rewrite context.

Closes #96030

…hen needed

Expand index.time_series.start_time and end_time to nanoseconds if timestamp field's resolution is set to nanoseconds. When creating coordinator rewrite context.

Closes elastic#96030
@elasticsearchmachine
Copy link
Collaborator

Hi @martijnvg, I've created a changelog YAML for you.

@martijnvg martijnvg marked this pull request as ready for review May 16, 2023 12:09
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 16, 2023
@salvatore-campagna
Copy link
Contributor

LGTM.

@martijnvg martijnvg added auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport-and-merge Automatically create backport pull requests and merge when ready labels May 24, 2023
@elasticsearchmachine elasticsearchmachine merged commit e7aef53 into elastic:main May 24, 2023
12 checks passed
@martijnvg martijnvg deleted the tsdb/range_query_skip_shard_issue branch May 24, 2023 08:30
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.8 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 96035

martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request May 24, 2023
…hen needed (elastic#96035)

Expand index.time_series.start_time and end_time to nanoseconds if
timestamp field's resolution is set to nanoseconds. When creating
coordinator rewrite context.

Closes elastic#96030
elasticsearchmachine pushed a commit that referenced this pull request May 24, 2023
…hen needed (#96035) (#96316)

Expand index.time_series.start_time and end_time to nanoseconds if
timestamp field's resolution is set to nanoseconds. When creating
coordinator rewrite context.

Closes #96030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.8.1 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range query on timestamp field can incorrectly exclude docs in tsdb data stream
3 participants