ES APM traces for HTTP requests include authn duration #96205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
changed the title
albertzaharovits
changed the title
albertzaharovits
added
>non-issue
:Core/Infra/Core
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-security (Team:Security) |
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Aug 1, 2023
In elastic#96205 we started recording the start time of the authn phase of REST request processing, because this happens too early to even start a span for the request. However we capture the threadpool's cached time which can be 200ms slow, yielding spans that appear much longer than they should. This commit moves to capturing the time using `System.currentTimeMillis` to avoid this problem.
DaveCTurner
added a commit
that referenced
this pull request
Aug 2, 2023
In #96205 we started recording the start time of the authn phase of REST request processing, because this happens too early to even start a span for the request. However we capture the threadpool's cached time which can be 200ms slow, yielding spans that appear much longer than they should. This commit moves to capturing the time using `System.currentTimeMillis` to avoid this problem.
DaveCTurner
added a commit
that referenced
this pull request
Aug 2, 2023
In #96205 we started recording the start time of the authn phase of REST request processing, because this happens too early to even start a span for the request. However we capture the threadpool's cached time which can be 200ms slow, yielding spans that appear much longer than they should. This commit moves to capturing the time using `System.currentTimeMillis` to avoid this problem. Backport of #98113 to 8.9
felixbarny
pushed a commit
to felixbarny/elasticsearch
that referenced
this pull request
Aug 3, 2023
In elastic#96205 we started recording the start time of the authn phase of REST request processing, because this happens too early to even start a span for the request. However we capture the threadpool's cached time which can be 200ms slow, yielding spans that appear much longer than they should. This commit moves to capturing the time using `System.currentTimeMillis` to avoid this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the changes in #95112, which relocated the calls into the
AuthenticationServicethat authenticate HTTP requests, the authentication duration was no longer comprised in between theTracer#startTraceandTracer#stopTrace. Consequently, the span records didn't cover the authentication duration any longer.This PR remedies that by changing the
Tracerimplementation, i.e.APMTracer, to look for the trace start time instant in the transient thread context and use that when starting traces (overriding thenowdefault). The trace start time is set in the thread context when the request-wise thread context is first populated (with HTTP request headers).