Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Lucene to a 9.7.0 snapshot #96433

Merged
merged 15 commits into from May 31, 2023

Conversation

javanna
Copy link
Member

@javanna javanna commented May 30, 2023

Most relevant changes:

As part of this PR I moved the ES codebase off of overriding or relying on the deprecated rewrite(IndexReader) method in favour of using rewrite(IndexSearcher) instead. For score functions, I went for not breaking existing plugins and create a new IndexSearcher whenever we rewrite a filter, otherwise we'd need to change the ScoreFunction#rewrite signature to take a searcher instead of a reader.

@javanna javanna added :Search/Search Search-related issues that do not fall into other categories >upgrade v8.9.0 labels May 30, 2023
@github-actions
Copy link

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label May 30, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

Hi @javanna, I've created a changelog YAML for you.

Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty
Copy link
Contributor

@elasticmachine run elasticsearch-ci/part-1

@ChrisHegarty
Copy link
Contributor

@elasticmachine run elasticsearch-ci/part-1

@ChrisHegarty
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs-check

@javanna javanna merged commit e5768d9 into elastic:main May 31, 2023
13 checks passed
@javanna javanna deleted the upgrade/lucene_9_7_snapshot branch May 31, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >upgrade v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants