-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add File Delivery index templates #96504
Conversation
Pinging @elastic/es-core-infra (Team:Core/Infra) |
I checked this out and tested it in combination with the following PRs to ensure that files uploaded from Kibana to ES and are downloaded by the Endpoint. PRs: Templates get installed by Fleet: When files get uploaded to Kibana, relevant docs are streamed in |
@@ -0,0 +1,25 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can probably delete these ilm policies since we know we need to use another method for this in serverless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the latest recommendation is to keep using ILM for stateful: https://github.com/elastic/ingest-dev/issues/1604#issuecomment-1536053175
@@ -0,0 +1,42 @@ | |||
{ | |||
"index_patterns": [ | |||
".fleet-filedelivery-data-*-*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we decide to move to data streams, these indices should be converted as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see comments.
…ents (#158773) ## Summary - Adds `const`'s for index patterns for files that are delivered to hosts/agents - modifies `createFilesClient.toHost()` (exposed in `Plugin.start()`) to use these new index names - Adds code to the package install flow to ensure new file delivery indexes are created - The files client factory now validates if the integration name is allowed to use fleet files functionality. FYI: PR that will add index mappings to ES: elastic/elasticsearch#96504
…ents (elastic#158773) ## Summary - Adds `const`'s for index patterns for files that are delivered to hosts/agents - modifies `createFilesClient.toHost()` (exposed in `Plugin.start()`) to use these new index names - Adds code to the package install flow to ensure new file delivery indexes are created - The files client factory now validates if the integration name is allowed to use fleet files functionality. FYI: PR that will add index mappings to ES: elastic/elasticsearch#96504
Adds two new index templates (
.fleet-filedevliery-meta-*-*
and.fleet-filedelivery-data-*-*
) for fleet usage, supporting a limited file-delivery feature through fleet.This follows a similar path as #91413 with somewhat different usage patterns.