Mappings: Remove support for field access by short name #9670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple fields under object fields share the same name, accessing by short name is ambiguous. This removes support for short names, always requiring the full name when used in queries. closes elastic#8872
rjernst
added
:Search/Mapping
|
I think this deserves an entry in the 2.0 migration guide? Otherwise LGTM |
|
@jpountz Good point, I've added an entry in the migration guide. Can you take a quick look? |
|
LGTM! |
This was referenced Apr 5, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple fields under object fields share the same name, accessing
by short name is ambiguous. This removes support for short names,
always requiring the full name when used in queries.
closes #8872
Note: I have an existing todo that I intend to commit, which is to in the future rename the name() function on doc field mappers. For now, it is just changed to be implemented with fullName. I did not want to litter this PR with a largish change (55 usages).