Fix bug when creating empty geo_lines #97509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>bug
:Analytics/Geo
|
Hi @iverase, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
craigtaverner
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Fascinating! I did not consider this edge case! An alternative implementation would be to change InternalGeoLine.reduce to not make the decision on non-overlapping based on it's own state, but on the state of all geo-lines being merged. We should only merge as non-overlapping if all geo-lines are non-overlapping. That would be a change to a single method.
craigtaverner
added
the
auto-backport-and-merge
This reverts commit 530e121.
craigtaverner
force-pushed
the
nonOverlapping
branch
from
17d631b
to
eac9de2
Compare
|
I am fine with your proposed fix and thanks for the test. |
💚 Backport successful
|
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Jul 10, 2023
During reduce, only merge as non-overlapping if all geo-lines are non-overlapping. --------- Co-authored-by: Craig Taverner <craig@amanzi.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 11, 2023
felixbarny
pushed a commit
to felixbarny/elasticsearch
that referenced
this pull request
Aug 3, 2023
During reduce, only merge as non-overlapping if all geo-lines are non-overlapping. --------- Co-authored-by: Craig Taverner <craig@amanzi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently creating empty geo_line with the flag non_overlapping equal to true which is causing issues when the driving geo_line for merging is this empty object. This PR make sure that empty geo_lines are created with the right flag.
fixes #97311