Changing watcher to disable cookies in shared http client #97591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Data Management
|
Hi @masseyke, I've created a changelog YAML for you. |
|
Pinging @elastic/es-data-management (Team:Data Management) |
jbaiera
approved these changes
Jul 12, 2023
mattc58
reviewed
Jul 13, 2023
| @@ -135,6 +135,12 @@ private CloseableHttpClient createHttpClient() { | |||
| clientBuilder.evictExpiredConnections(); | |||
| clientBuilder.setMaxConnPerRoute(MAX_CONNECTIONS); | |||
| clientBuilder.setMaxConnTotal(MAX_CONNECTIONS); | |||
| /* | |||
| * This client will potentially be used by multiple users. We do not want it to keep any state like cookies, because that will | |||
| * result in that state unexpectedlky being shared across all users. | |||
JVerwolf
pushed a commit
to JVerwolf/elasticsearch
that referenced
this pull request
Aug 15, 2023
csoulios
pushed a commit
to csoulios/elasticsearch
that referenced
this pull request
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watcher uses a single apache http client to make all outgoing connections. This client is shared by any user of the watcher API, as well as scheduled watches. Currently this client supports cookies. A cookie set for one user will be shared by all users. Watcher is meant to be used with stateless http requests, so cookies don't offer any advantage. But it could cause problems if they are shared across users.