Fork response reading in TransportNodesAction #97899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All `TransportNodesAction` implementations fork before computing the final response, but in some cases (notably `TransportNodesStatsAction`) even reading the node-level responses is too expensive to run on a `transport_worker` thread. With this commit we fork the deserialization of the node-level responses to the final executor too.
DaveCTurner
added
>bug
:Distributed/Distributed
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
|
Pinging @elastic/es-distributed (Team:Distributed) |
pxsalehi
approved these changes
Jul 24, 2023
felixbarny
pushed a commit
to felixbarny/elasticsearch
that referenced
this pull request
Aug 3, 2023
All `TransportNodesAction` implementations fork before computing the final response, but in some cases (notably `TransportNodesStatsAction`) even reading the node-level responses is too expensive to run on a `transport_worker` thread. With this commit we fork the deserialization of the node-level responses to the final executor too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
TransportNodesActionimplementations fork before computing the finalresponse, but in some cases (notably
TransportNodesStatsAction) even readingthe node-level responses is too expensive to run on a
transport_workerthread. With this commit we fork the deserialization of the node-level
responses to the final executor too.