[buildkite] Add Windows packaging and platform support tests to periodic pipeline #98072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
approved these changes
Aug 8, 2023
|
|
||
| SET JAVA_HOME=%USERPROFILE%\.java\%ES_BUILD_JAVA% | ||
| SET JAVA11_HOME=%USERPROFILE%\.java\java11 | ||
| SET JAVA16_HOME=%USERPROFILE%\.java\openjdk16 |
There was a problem hiding this comment.
Hmm, I'm wondering why we'd need Java 16. I think we can ditch this.
| @@ -121,12 +121,12 @@ buildScan { | |||
| buildScanPublished { scan -> | |||
| // Attach build scan link as build metadata | |||
| // See: https://buildkite.com/docs/pipelines/build-meta-data | |||
| ['buildkite-agent', 'meta-data', 'set', "build-scan-${System.getenv('BUILDKITE_JOB_ID')}", "${scan.buildScanUri}"].execute() | |||
| new ProcessBuilder('buildkite-agent', 'meta-data', 'set', "build-scan-${System.getenv('BUILDKITE_JOB_ID')}", "${scan.buildScanUri}").start() | |||
There was a problem hiding this comment.
Should we also call waitFor() here?
There was a problem hiding this comment.
Oops, yep, thanks.
brianseeders
added a commit
to brianseeders/elasticsearch
that referenced
this pull request
Aug 9, 2023
…dic pipeline (elastic#98072) (cherry picked from commit dfadca8)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
brianseeders
added a commit
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the platform/packaging tests that are run on Windows to the new Buildkite periodic pipeline.
Linux jobs will be added in a separate PR.
See here for test builds: https://buildkite.com/elastic/brianseeders-elasticsearch-sandbox/builds?branch=buildkite-migration-periodic-windows
See also: https://elasticco.atlassian.net/jira/software/c/projects/ES/boards/297?modal=detail&selectedIssue=ES-6358
run-gradle.shalso work with Windows (previously unix only)ProcessBuilder.start()