Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork CCS remote-cluster responses #98124

Merged
merged 3 commits into from Aug 8, 2023
Merged

Fork CCS remote-cluster responses #98124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bee598
Fork CCS remote-cluster responses
DaveCTurner Aug 2, 2023
4515419
Update docs/changelog/98124.yaml
DaveCTurner Aug 2, 2023
b67700c
Spotless
DaveCTurner Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/changelog/98124.yaml
View file
Open in desktop
@@ -0,0 +1,6 @@
pr: 98124
summary: Fork CCS remote-cluster responses
area: Search
type: bug
issues:
- 97997
4 changes: 1 addition & 3 deletions server/src/main/java/org/elasticsearch/action/search/TransportSearchAction.java
View file
Open in desktop
Expand Up @@ -44,7 +44,6 @@
import org.elasticsearch.common.settings.Setting.Property;
import org.elasticsearch.common.util.Maps;
import org.elasticsearch.common.util.concurrent.CountDown;
import org.elasticsearch.common.util.concurrent.EsExecutors;
import org.elasticsearch.core.Nullable;
import org.elasticsearch.core.TimeValue;
import org.elasticsearch.index.Index;
Expand Down Expand Up @@ -467,8 +466,7 @@ static void ccsRemoteReduce(
ActionListener<SearchResponse> listener,
BiConsumer<SearchRequest, ActionListener<SearchResponse>> localSearchConsumer
) {
// TODO pick a more appropriate executor for this work - see https://github.com/elastic/elasticsearch/issues/97997
final var remoteClientResponseExecutor = EsExecutors.DIRECT_EXECUTOR_SERVICE;
final var remoteClientResponseExecutor = threadPool.executor(ThreadPool.Names.SEARCH_COORDINATION);
if (localIndices == null && remoteIndices.size() == 1) {
// if we are searching against a single remote cluster, we simply forward the original search request to such cluster
// and we directly perform final reduction in the remote cluster
Expand Down