New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read operator privs enabled from Env settings #98246
Read operator privs enabled from Env settings #98246
Conversation
Security.settings incorrectly caches the node startup settings which does not take into account setting changes that may take place after the node has started (e.g. "addtionalSettings()" from plugins). This commit fixes the behaviour for the OperatorPrivileges enabled setting, until the bug can be fixed more generally
Hi @tvernum, I've created a changelog YAML for you. |
Pinging @elastic/es-security (Team:Security) |
I'd love to fix the bug more generally - this elasticsearch/x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/Security.java Lines 560 to 561 in c9c2f76
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FWIW, I had to do something similar for the recent work of supporting overridden builtin roles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing !
Security.settings incorrectly caches the node startup settings which does not take into account setting changes that may take place after the node has started (e.g. "addtionalSettings()" from plugins).
This commit fixes the behaviour for the OperatorPrivileges enabled setting, until the bug can be fixed more generally