Reset GatewayService flags before reroute #98653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible (although very unlikely) that the `GatewayService` recovers the state, then fails over to a new master with unrecovered state, and then fails back to the original master, and only then performs the reroute that resets the flags which would trigger another state recovery attempt. This leaves the cluster in an unrecovered state until the next cluster state update. This commit resets the flags at the end of the recovery update rather than waiting until after the reroute, allowing a subsequent election to retry recovery again. Closes elastic#98606
DaveCTurner
added
>bug
:Distributed/Cluster Coordination
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
DaveCTurner
deleted the
2023/08/21/testClusterRecoversAfterExceptionDuringSerialization
branch
dreamquster
pushed a commit
to dreamquster/elasticsearch
that referenced
this pull request
Aug 26, 2023
It's possible (although very unlikely) that the `GatewayService` recovers the state, then fails over to a new master with unrecovered state, and then fails back to the original master, and only then performs the reroute that resets the flags which would trigger another state recovery attempt. This leaves the cluster in an unrecovered state until the next cluster state update. This commit resets the flags at the end of the recovery update rather than waiting until after the reroute, allowing a subsequent election to retry recovery again. Closes elastic#98606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible (although very unlikely) that the
GatewayServicerecovers the state, then fails over to a new master with unrecovered
state, and then fails back to the original master, and only then
performs the reroute that resets the flags which would trigger another
state recovery attempt. This leaves the cluster in an unrecovered state
until the next cluster state update.
This commit resets the flags at the end of the recovery update rather
than waiting until after the reroute, allowing a subsequent election to
retry recovery again.
Closes #98606