Change EngineTestCase to not wrap the reader. #98732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part elastic#98110, EngineTestCase now uses newSearcher() to create a new index searcher (instead of just creating a new index searcher). This is for increasing test coverage. However, this test can't deal with wrapping the index reader as it leads to assertion errors. So instead use `newSearcher(leaf, false)` to still keep to test benefits of wrapping the index searcher. Closes elastic#98716
martijnvg
added
>test
|
Pinging @elastic/es-search (Team:Search) |
|
@elasticmachine update branch |
martijnvg
added
the
auto-merge
dreamquster
pushed a commit
to dreamquster/elasticsearch
that referenced
this pull request
Aug 26, 2023
As part elastic#98110, EngineTestCase now uses newSearcher() to create a new index searcher (instead of just creating a new index searcher). This is for increasing test coverage. However, this test can't deal with wrapping the index reader as it leads to assertion errors. So instead use `newSearcher(leaf, false)` to still keep to test benefits of wrapping the index searcher. Closes elastic#98716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part #98110, EngineTestCase now uses newSearcher() to create a new index searcher (instead of just creating a new index searcher). This is for increasing test coverage. However, this test can't deal with wrapping the index reader as it leads to assertion errors. So instead use
newSearcher(leaf, false)to still keep to test benefits of wrapping the index searcher.Closes #98716