ESQL: Add CEIL function
#98847
Merged
ESQL: Add CEIL function
#98847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instructions for running them from Intellij may not work due to classpath issues etc. They do not work for devs using Intellij on Windows.
alex-spies
added
>enhancement
Team:QL (Deprecated)
|
Documentation preview: |
elasticsearchmachine
added
needs:triage
alex-spies
commented
Aug 24, 2023
Comment on lines
+42
to
+43
| * from within Intellij or, alternatively, via Gradle: | ||
| * {@code ./gradlew -p x-pack/plugin/esql test --tests "org.elasticsearch.xpack.esql.CsvTests"} |
There was a problem hiding this comment.
Added this because, at least on my Windows, running from within Intellij IDEA does not work for some classpath/dependency resolution reasons.
alex-spies
added
Team:QL (Deprecated)
|
@elasticsearchmachine run Check labels |
|
Pinging @elastic/es-ql (Team:QL) |
|
Hi @alex-spies, I've created a changelog YAML for you. |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
nik9000
approved these changes
Aug 24, 2023
Add generated signature and permitted types
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
|
Hm, |
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
x-pack/plugin/esql/qa/testFixtures/src/main/resources/math.csv-spec
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/qa/testFixtures/src/main/resources/math.csv-spec
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the unary scalar function
CEIL.It takes a single double argument which is rounded up, and is a noop for integer arguments. Analogous to
FLOOR.CEIL, add it to the function registry and make sure it is serializable.CEILandFLOORFLOOR.