Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Kibana system index does not allow user templates to affect it (#98696)" #98888

Merged
merged 2 commits into from Aug 25, 2023

Conversation

azasypkin
Copy link
Member

Summary

This reverts commit 2239321.

This change caused the Kibana compatibility test (7.17.x <-> 8.x.x) to fail (https://buildkite.com/elastic/kibana-7-dot-17-es-8-dot-11-forward-compatibility/builds/9#018a2868-e94d-4741-a96d-2bedbc991d1c). The reason for this failure is that we still rely on an index template for one of the .kibana_ prefixed indices in 7.17, specifically .kibana_security_session_1. After discussing in Slack, we've decided that it's safer to revert this change rather than backporting this PR that removed the dependency on the index template to 7.17.

We can revisit and re-implement this change once 7.17 reaches its End of Life.

cc @rudolf @gwbrown

@azasypkin azasypkin added >bug :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team labels Aug 25, 2023
@elasticsearchmachine
Copy link
Collaborator

@azasypkin please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added v8.11.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 25, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @azasypkin, I've created a changelog YAML for you.

@azasypkin azasypkin marked this pull request as ready for review August 25, 2023 16:55
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@williamrandolph williamrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reversion looks clean and safe to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Core Core issues without another label external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Core/Infra Meta label for core/infra team v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants