Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoexpand during node replace #98891

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

kingherc
Copy link
Contributor

Backport of PR #96281 amended for 7.17.x. As a reviewer, it may be a good idea to compare the diff of this PR with the diff of this PR.

Tried to be as least intrusive to the allocation decision explanations of 7.17.x as possible.

Closes #89527

idegtiarenko and others added 3 commits August 25, 2023 19:05
Prior to this change NodeReplacementAllocationDecider was unconditionally
skipping both replacement source and target nodes when calculation auto-expand
replicas. This is fixed by autoexpanding to the replacement node if source node
already had shards of the index

Backport of PR elastic#96281 amended for 7.17.x

Closes elastic#89527
@kingherc kingherc added >bug :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) backport Team:Core/Infra Meta label for core/infra team :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown v7.17.13 labels Aug 25, 2023
@kingherc kingherc self-assigned this Aug 25, 2023
@kingherc kingherc added the Team:Distributed Meta label for distributed team label Aug 25, 2023
@kingherc kingherc merged commit f7af19b into elastic:7.17 Aug 28, 2023
9 checks passed
@kingherc kingherc deleted the bugfix/89527-backport-717 branch August 28, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport >bug :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Core/Infra Meta label for core/infra team Team:Distributed Meta label for distributed team v7.17.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants