Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Persian language stemmer #99106

Merged
merged 1 commit into from Sep 5, 2023
Merged

Add Persian language stemmer #99106

merged 1 commit into from Sep 5, 2023

Conversation

rezatorabi
Copy link
Contributor

This pull request adds a stemmer for the Persian (Farsi) language. It is trying to fix #98911.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.11.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 31, 2023
@arteam arteam added :Search/Analysis How text is split into tokens >enhancement labels Sep 1, 2023
@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team and removed needs:triage Requires assignment of a team area label labels Sep 1, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@rezatorabi
Copy link
Contributor Author

@mayya-sharipova
Hi Mayya.
Could you please review this pull request? It won't take long.
Sorry if I mentioned you wrong. You were the only one who had any kind of interaction with the related issue.

@romseygeek romseygeek self-assigned this Sep 5, 2023
@romseygeek
Copy link
Contributor

@elasticmachine ok to test

@romseygeek
Copy link
Contributor

Thanks for opening this PR @rezatorabi! It looks good to me overall. I've triggered CI on it which may find some nits, let's see what it comes up with.

romseygeek
romseygeek reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy and so am I!

@romseygeek romseygeek merged commit 310af09 into elastic:main Sep 5, 2023
14 checks passed
@romseygeek
Copy link
Contributor

Thanks @rezatorabi

@rezatorabi
Copy link
Contributor Author

Thanks @romseygeek for the fast review and merge.

@rezatorabi rezatorabi deleted the persian-stemmer branch September 5, 2023 11:33
alex-spies pushed a commit to dreamquster/elasticsearch that referenced this pull request Sep 8, 2023
@rezatorabi @alex-spies
Add persian language stemmer (elastic#99106)
07e2f5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees

@romseygeek romseygeek

Labels
>enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team :Search/Analysis How text is split into tokens Team:Search Meta label for search team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Persian language stemmer (token filter)
4 participants
@rezatorabi @elasticsearchmachine @romseygeek @arteam