Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork response-sending in OpenPointInTimeAction #99222

Conversation

DaveCTurner
Copy link
Contributor

Creating the response after opening a PIT involves O(#shards) work and
has been observed to block transport worker threads which disrupts the
cluster. This commit forks this work onto a more appropriate thread.

Creating the response after opening a PIT involves O(#shards) work and
has been observed to block transport worker threads which disrupts the
cluster. This commit forks this work onto a more appropriate thread.
@DaveCTurner DaveCTurner added >bug :Search/Search Search-related issues that do not fall into other categories v8.11.0 labels Sep 6, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Sep 6, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

Hi @DaveCTurner, I've created a changelog YAML for you.

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @DaveCTurner

@DaveCTurner DaveCTurner merged commit 5b0fba1 into elastic:main Sep 6, 2023
12 checks passed
@DaveCTurner DaveCTurner deleted the 2023/09/06/OpenPointInTimeAction-fork-response branch September 6, 2023 14:19
alex-spies pushed a commit to dreamquster/elasticsearch that referenced this pull request Sep 8, 2023
Creating the response after opening a PIT involves O(#shards) work and
has been observed to block transport worker threads which disrupts the
cluster. This commit forks this work onto a more appropriate thread.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants