Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove "coming" notification #99494

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

JVerwolf
Copy link
Contributor

Removes the "coming" notifications now that the final release of 8.10.0 is cut.

@JVerwolf JVerwolf added >docs General docs changes v8.10.1 labels Sep 12, 2023
@github-actions
Copy link

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Sep 12, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@JVerwolf
Copy link
Contributor Author

This fails with or without the seed, and it also fails on branch 8.10, so this is a pre-existing bug. However, it does not fail on main.

e.g.:

./gradlew ':docs:yamlRestTest' --tests "org.elasticsearch.smoketest.DocsClientYamlTestSuiteIT.test {yaml=reference/indices/shard-stores/line_150}" -Dtests.seed=A212D1FB2DD52FC4 -Dtests.locale=ru -Dtests.timezone=America/Montreal -Druntime.java=20

This triggers the failure by executing this test:
https://github.com/JVerwolf/elasticsearch/blob/b5e06da143bebe9aa0ecba8a7ddddccb3be21c7c/docs/reference/indices/shard-stores.asciidoc#L149-L154

I'll run a git bisect to find the offending commit.

@JVerwolf
Copy link
Contributor Author

JVerwolf commented Sep 12, 2023

git biesect output:

b61a2561d4f177f74216b45870ba5f8f0c993956 is the first bad commit
commit b61a2561d4f177f74216b45870ba5f8f0c993956
Author: Mark Vieira <portugee@gmail.com>
Date:   Tue Sep 12 10:07:38 2023 -0700

    Bump versions after 8.10.0 release

 .backportrc.json                                             |  4 ++--
 .buildkite/pipelines/intake.yml                              |  2 +-
 .buildkite/pipelines/periodic-packaging.yml                  | 12 ++++++------
 .buildkite/pipelines/periodic.yml                            | 12 ++++++------
 .ci/bwcVersions                                              |  2 +-
 .ci/snapshotBwcVersions                                      |  3 +--
 build-tools-internal/version.properties                      |  2 +-
 server/src/main/java/org/elasticsearch/Version.java          |  4 ++--
 .../src/main/java/org/elasticsearch/index/IndexVersion.java  |  4 ++--
 9 files changed, 22 insertions(+), 23 deletions(-)
bisect found first bad commit%

This is referencing this commit: b61a256

I believe this is the commit to finalize the release.

@mark-vieira Do you know what's going on here?

@jrodewig
Copy link
Contributor

@elasticsearchmachine update branch

@jrodewig
Copy link
Contributor

@JVerwolf I'm pretty sure this is related to #99495. Updating the branch should fix it. If not, I'll push another commit to fix the failing test.

@jrodewig
Copy link
Contributor

@JVerwolf Checks have passed now. Sorry for causing the delay here.

@JVerwolf JVerwolf merged commit 1c2586d into elastic:8.10 Sep 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes Team:Docs Meta label for docs team v8.10.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants