Close expired search contexts on SEARCH thread #99660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a production cluster, I observed the `[scheduler]` thread stuck for a while trying to delete index files that became unreferenced while closing a search context. We shouldn't be doing I/O on the scheduler thread. This commit moves it to a `SEARCH` thread instead.
DaveCTurner
added
>bug
:Search/Search
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search (Team:Search) |
DaveCTurner
added
the
auto-merge
|
I'm marking this for backport, it looks to be quite a problem in this one (7.17) cluster. |
DaveCTurner
added a commit
that referenced
this pull request
Sep 19, 2023
In a production cluster, I observed the `[scheduler]` thread stuck for a while trying to delete index files that became unreferenced while closing a search context. We shouldn't be doing I/O on the scheduler thread. This commit moves it to a `SEARCH` thread instead.
DaveCTurner
added a commit
that referenced
this pull request
Sep 19, 2023
In a production cluster, I observed the `[scheduler]` thread stuck for a while trying to delete index files that became unreferenced while closing a search context. We shouldn't be doing I/O on the scheduler thread. This commit moves it to a `SEARCH` thread instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a production cluster, I observed the
[scheduler]thread stuck for awhile trying to delete index files that became unreferenced while
closing a search context. We shouldn't be doing I/O on the scheduler
thread. This commit moves it to a
SEARCHthread instead.