ESQL: Lower the implicit limit, if none is user-provided #99816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lowers the implicit (max) 10K limit to 500 (default). The new default limit is only added if no other limit is detected after the last pipeline breaker. Otherwise the capping max limit is applied.
If any limit is provided in the query, only apply the max capping.
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
|
Hi @bpintea, I've created a changelog YAML for you. |
|
@elasticsearchmachine run elasticsearch-ci/part-3 |
costin
approved these changes
Sep 22, 2023
Opened #99880 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 26, 2023
Document the newly implicit limit of 500 (if no other limit is provided), as well as the global 10K one. Related: #99816
piergm
pushed a commit
to piergm/elasticsearch
that referenced
this pull request
Oct 2, 2023
Document the newly implicit limit of 500 (if no other limit is provided), as well as the global 10K one. Related: elastic#99816
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Oct 18, 2023
Fixes elastic#100555 ESQL [by default](elastic#99816) adds an implicit `LIMIT 500` to queries that do not define a limit. Since this can be confusing for the end user, with this PR we also add a warning to the response, making this default clear and explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lowers the implicit (max) 10K limit to 500 (default). The new
default limit is only added if no other limit is detected anywhere
in the query (i.e. also before a pipeline breaker, like stats).
Otherwise the capping max limit is applied (as before).
The default limit is made a node setting, like the max results limit.
Closes #99458.