Add checks in term and terms queries that input terms are not too long #99818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>enhancement
:Search/Search
|
Hi @romseygeek, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search (Team:Search) |
…bug/long-term-queries
server/src/main/java/org/elasticsearch/index/query/AbstractQueryBuilder.java
Show resolved
Hide resolved
mayya-sharipova
approved these changes
Sep 22, 2023
martijnvg
approved these changes
Sep 25, 2023
| * @param input an input BytesRef | ||
| * @return a String prefix | ||
| */ | ||
| public static String safeStringPrefix(BytesRef input, int prefixLength) { |
There was a problem hiding this comment.
Is this method intended to be used elsewhere or only a helper method for checkIndexableLength(...)?
In the latter case, maybe make this a private helper method?
There was a problem hiding this comment.
Yep, that's a good call, will make this private.
|
Should this change be back ported to the 8.10 branch? |
Yes, good idea. |
romseygeek
added
v8.10.3
auto-backport-and-merge
💚 Backport successful
|
romseygeek
added a commit
to romseygeek/elasticsearch
that referenced
this pull request
Sep 25, 2023
elastic#99818) Lucene indexes do not allow terms of greater than 32k bytes long. Any queries that contain terms that exceed this length will by definition not match anything, and can cause cluster instability by consuming large amounts of heap. They are also generally always a user error (for example, a termsquery that concatenates all its inputs into a single string rather than splitting them into json arrays). This commit adds some checking to Term and Terms query builders that will throw an exception if any of their input terms are greater than the maximum allowed length by the lucene IndexWriter. Fixes elastic#99802
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 25, 2023
#99818) (#99863) Lucene indexes do not allow terms of greater than 32k bytes long. Any queries that contain terms that exceed this length will by definition not match anything, and can cause cluster instability by consuming large amounts of heap. They are also generally always a user error (for example, a termsquery that concatenates all its inputs into a single string rather than splitting them into json arrays). This commit adds some checking to Term and Terms query builders that will throw an exception if any of their input terms are greater than the maximum allowed length by the lucene IndexWriter. Fixes #99802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucene indexes do not allow terms of greater than 32k bytes long. Any queries that
contain terms that exceed this length will by definition not match anything, and can
cause cluster instability by consuming large amounts of heap. They are also generally
always a user error (for example, a termsquery that concatenates all its inputs into
a single string rather than splitting them into json arrays).
This commit adds some checking to Term and Terms query builders that will throw an
exception if any of their input terms are greater than the maximum allowed length by
the lucene IndexWriter.
Fixes #99802