Skip to content

Commit

Permalink
Revert changes to USA States layer in EMS 8.0 (#230)
Browse files Browse the repository at this point in the history
In #152 we changed the `name` field to `label_en` in the USA States layer in EMS 8+ to match the precedent with other country subdivisions. To make this change transparent to users, we need to have a saved object migration for term joins, styles, and tooltips that use the `name` field.

This PR proposes we delay the changes to the USA States layer to give us more time to implement the saved object migration in Kibana. With a proper migration it should be possible to implement this layer change in a minor EMS release (e.g. 8.1).  In that case we could change the `versions` in the `states_v1.hjson` and `states_v8.hjson` configs to be `1 - 8.0` and `>= 8.1` respectively.
  • Loading branch information
nickpeihl committed Oct 21, 2021
1 parent 63551b2 commit f3d334b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion sources/us/states_v1.hjson
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
versions: '1 - 7'
versions: '1 - 8'
production: true
countryCode: US
type: http
Expand Down
5 changes: 3 additions & 2 deletions sources/us/states_v8.hjson
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
versions: '>=8'
production: true
// TODO Layer is disabled until we have proper migrations in kibana
versions: '>=9'
production: false
countryCode: US
type: http
note: States of United States
Expand Down

0 comments on commit f3d334b

Please sign in to comment.