Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on countries source id #199

Merged
merged 2 commits into from Oct 28, 2020
Merged

Fix error on countries source id #199

merged 2 commits into from Oct 28, 2020

Conversation

jsanz
Copy link
Member

@jsanz jsanz commented Oct 28, 2020

Fixes #198

When creating the new World Countries layer I used the same source identifier, which made the v2 manifest to point to a blob that contains the TopoJSON version of the dataset.

To check this PR works the simplest way is to see that the staging manifest for v2 points to the GeoJSON dataset

$ curl -s --compressed https://storage.googleapis.com/elastic-bekitzur-emsfiles-vector-dev/v2/manifest\?elastic_tile_service_tos\=agree\&my_app_name\=ems-landing\&my_app_version\=7.2.0\&license\=643c1faf-80fc-4ab0-9323-4d9bd11f4bbc | jq '.layers[0].url'
"https://storage.googleapis.com/elastic-bekitzur-emsfiles-vector-dev/blob/5659313586569216?elastic_tile_service_tos=agree"
$ curl -s --compressed "https://storage.googleapis.com/elastic-bekitzur-emsfiles-vector-dev/blob/5659313586569216?elastic_tile_service_tos=agree" | jq '.features[0].properties'
{
  "name": "Antigua and Barbuda",
  "iso2": "AG",
  "iso3": "ATG"
}

@jsanz jsanz added bug Something isn't working data Data related issues and requests labels Oct 28, 2020
@jsanz jsanz requested a review from nickpeihl October 28, 2020 16:50
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit, but otherwise lgtm!

sources/world/world_countries_v2.hjson Outdated Show resolved Hide resolved
@kibanamachine
Copy link

💚 Build Succeeded

makes sense, thanks

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
@kibanamachine
Copy link

💚 Build Succeeded

@jsanz jsanz merged commit 883696f into master Oct 28, 2020
@jsanz jsanz deleted the feature-layers branch October 28, 2020 17:59
@jsanz jsanz restored the feature-layers branch October 28, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data Data related issues and requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

World Countries not working in Version 2
3 participants