Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add country layers for administrative divisions in Arabian peninsula #226

Merged
merged 10 commits into from
Sep 27, 2021

Conversation

nickpeihl
Copy link
Member

Fixes #224

The boundaries come from our Administrative Regions layer which is based on Natural Earth Data. I added Arabic names from Natural Earth Data when available and Wikidata.

To preview these layers, visit the links below.

@kibanamachine
Copy link

💔 Build Failed

query: {}
name: 'uae_emirates'
legacyIds: [
'UAE Emirates'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, United Arab Emirates emirates or Emirates of United Arab Emirates or just United Arab Emirates? 🤷 😅

UAE is shorter and fits better in the ToC. See also USA States. But I can understand if we want to avoid shortening the name. Any thoughts @jsanz @kelastic?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickpeihl thank you for your help with this.

UAE Emirates (with a capital E) makes sense to me, since it would be similar to USA States: https://maps.elastic.co/#file/usa_states

For https://maps.elastic.co/?manifest=testing#file/uae_emirates would it please be possible to add an Arabic label for "Neutral Zone"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kelastic I did some cursory research on these "Neutral Zones" and they appear to be disputed territories with neighboring countries. From the worldview perspective of UAE, these are UAE territories. But they are de facto controlled by other entities.

Since this layer is only UAE territories, I'm considering merging these "Neutral Zones" into their respective emirates in UAE. We have already established a precedent for merging disputed territories into specific country layers such as the Kashmir region in India States layer and Taiwan in the China Provinces layer. To avoid topological inconsistencies, we will still maintain a separate opinionated worldview in the World Countries and Administrative regions layers.

Do you agree that we could include these disputed territories as part of UAE?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* Merge neutral areas into specific emirates
* Makefile instructions for recreating layers
* Documentation
@kibanamachine
Copy link

💔 Build Failed

@kibanamachine
Copy link

💚 Build Succeeded

Copy link
Member

@jsanz jsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look OK to me, thanks for documenting the procedure in the Makefile scripts 👏

I have only a question. The CSVs info that adds the Arabic names is coming from Natural Earth, OSM or Wikidata? If the last we need then to add the proper attribution.

Thanks!

@nickpeihl
Copy link
Member Author

I have only a question. The CSVs info that adds the Arabic names is coming from Natural Earth, OSM or Wikidata? If the last we need then to add the proper attribution.

Arabic names come from Natural Earth or Wikidata. I'll document this. Thanks.

* Added instructions for using `make`
* Removed script from README as it is now in the Makefile
@kibanamachine
Copy link

💚 Build Succeeded

@nickpeihl
Copy link
Member Author

@kelastic do you mind doing another review of this when you have time?

@kelastic
Copy link

kelastic commented Sep 23, 2021

@nickpeihl I noticed that the English names used for Bahrain (and two for Qatar and one for Yemen) make heavy use of diacritics, but the others do not use diacritics. I'm not saying that this is wrong, but rather I'm asking if we are being consistent with the Romanisation of Arabic place names?

@kelastic
Copy link

@nickpeihl Also, will using diacritics make it more difficult to search for these English names, if the user's keyboard does not have these diacritics easily available?

@nickpeihl
Copy link
Member Author

@nickpeihl I noticed that the English names used for Bahrain (and two for Qatar and one for Yemen) make heavy use of diacritics, but the others do not use diacritics. I'm not saying that this is wrong, but rather I'm asking if we are being consistent with the Romanisation of Arabic place names?

The Romanisation is only as consistent as the upstream data source which, in this case, is Natural Earth. With few exceptions, our precedent is to keep as close to the source data as possible. This makes it easier to apply updates automatically.

That said, I'm not opposed to making exceptions. But I would prefer to rely on a definitive purpose for going against precedent.

@nickpeihl Also, will using diacritics make it more difficult to search for these English names, if the user's keyboard does not have these diacritics easily available?

Are you asking about searching in Elasticsearch? The default standard analyzer could be used to search without requiring the user to type diacritics. I have an example below that you can copy and paste into the Dev Console in Kibana.

Click to expand demo
PUT qatar_test
{
  "mappings": {
    "properties": {
      "label_en": { 
        "type": "text", 
        "analyzer": "standard"
      },
      "label_ar": {
        "type": "text",
        "analyzer": "arabic"
      }
    }
  }
}

PUT qatar_test/_doc/1
{
  "label_en": "Ash Shīḩānīyah",
  "label_ar": "الشحانية"
}

GET qatar_test/_search
{
  "query": {
    "match": {
      "label_en": {
        "query": "Ash Shihaniyah"
      }
    }
  }
}

@kelastic
Copy link

@nickpeihl Thanks for the clarifications. I agree with you, let's keep things as they are currently.

@nickpeihl nickpeihl merged commit 2bcab8c into master Sep 27, 2021
@nickpeihl nickpeihl deleted the feature-layers branch September 27, 2021 15:40
@nickpeihl nickpeihl restored the feature-layers branch September 27, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add administrative region layers for countries in the Arabian Peninsula
4 participants