Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added documents_volume fields #188

Merged
merged 4 commits into from
Sep 10, 2021
Merged

added documents_volume fields #188

merged 4 commits into from
Sep 10, 2021

Conversation

intxgo
Copy link
Contributor

@intxgo intxgo commented Sep 1, 2021 •
edited
Loading

Added documents volume metrics fields.

@pzl
Copy link
Member

pzl commented Sep 3, 2021

please pull in master and run make (make -j8 may speed it up for you) and add those changes to your PR.

There are a few generated files that update based on these changes

@intxgo
Copy link
Contributor Author

intxgo commented Sep 8, 2021

please pull in master and run make (make -j8 may speed it up for you) and add those changes to your PR.

There are a few generated files that update based on these changes

done

@pzl
Copy link
Member

pzl commented Sep 8, 2021

the Makefile has changed since you started this branch/pull-request. I'm not sure you've pulled those changes in. There are two files (generated/metrics/ecs/subset/metrics/ecs_flat.yml and generated/metrics/elasticsearch/component/Endpoint.json) which are not being created anymore in the new Makefile.

that should be the only tangible change, if you can remove those two files, the conflicts should be gone and we can review this

@intxgo intxgo force-pushed the 8847_documents_volume_metrics branch from eaef27e to 5156daf Compare September 10, 2021 13:34
@intxgo intxgo merged commit f57b161 into master Sep 10, 2021
@intxgo intxgo deleted the 8847_documents_volume_metrics branch September 10, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzl pzl pzl approved these changes

@gogochan gogochan gogochan approved these changes

@ferullo ferullo ferullo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@intxgo @pzl @gogochan @ferullo