Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s mappings added to process/alerts datastream to support new k8s da… #264

Merged
merged 5 commits into from
Jun 21, 2022

Conversation

mitodrummer
Copy link
Contributor

…shboard

Change Summary

Issue: https://github.com/elastic/security-team/issues/4166

There are a number of fields which are new in 8.3, so i've commented out those 4 mappings until endpoint-package can point to 8.3 ECS.

Release Target

8.4

Q/A

For mapping changes:

  • I ran make after making the schema changes, and committed any generated files (in schema/, generated/)

For Transform changes:

  • The new transform successfully starts in Kibana
  • The corresponding transform destination schema was updated if necessary

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 20, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-21T19:59:26.100+0000

  • Duration: 7 min 25 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitodrummer This looks good

Can you update the tests with sample values for the fields being added?

The sample files are:

  • package/endpoint/data_stream/alerts/sample_event.json
  • package/endpoint/data_stream/process/sample_event.json

@pzl pzl added the v8.4.0 label Jun 21, 2022
@mitodrummer mitodrummer requested a review from pzl June 21, 2022 19:14
Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mitodrummer mitodrummer merged commit 0200fe9 into master Jun 21, 2022
@pzl pzl deleted the k8s_mappings_for_process_model branch June 22, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants