Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add process.end #273

Merged
merged 3 commits into from
Jul 21, 2022
Merged

add process.end #273

merged 3 commits into from
Jul 21, 2022

Conversation

ferullo
Copy link
Contributor

@ferullo ferullo commented Jul 20, 2022

Change Summary

Add process.end from ECS into Endpoint process documents.

Sample values

See blow

Sample document:
Heavily redacted/snipped example:

{
    "message": "Endpoint process event",
    "process": {
        "end": "2022-07-18T21:05:19.9419692Z"
    }
}

Release Target

8.4

Q/A

N/A

For mapping changes:

  • I ran make after making the schema changes, and committed all changes
  • If these field(s) are "exception"-able, I made a companion PR to Kibana adding it (see Readme)
  • If this is a metadata change, I also updated both transform destination schemas to match

For Transform changes:

  • The new transform successfully starts in Kibana
  • The corresponding transform destination schema was updated if necessary

@pzl
Copy link
Member

pzl commented Jul 20, 2022

@ferullo can you add that sample value ( "end": "2022-07-18T21:05:19.9419692Z" ) to the document in package/endpoint/data_stream/process/sample_event.json ?

just adding that single field to the existing doc will work and then keep the tests up-to-date.

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 20, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-20T17:12:30.477+0000

  • Duration: 17 min 30 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ferullo
Copy link
Contributor Author

ferullo commented Jul 20, 2022

👍 done

@ferullo ferullo merged commit dc33874 into master Jul 21, 2022
@ferullo ferullo deleted the process.end branch July 21, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants