-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Terminal output] Fields coming in 8.5 added to custom_schemas/subsets #294
Conversation
Had this problem in my last PR, but for some reason i'm not getting all the generate artifacts, and so haven't been able to validate these changes work... hopefully CI will give some insights. |
Yup, so for some reason, make or make -B is not producing the expected generated schemas.. I'm using ubuntu 22 with python3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We seem to be losing some top-level definitions of the tty
object here. the sub-fields under it (eg X.tty.Y
seem to still be here, just the docs and description of the tty
object, which is strange.
Not sure if that's intentional or we have some out-of-date ECS building happening
Yea that is strange, I wonder if the custom_schemas changes are some how overriding everything else under the tty object. I can try and include the rest of the fields for the tty object to see if that fixes it. Though, my local build issues are a blocker at the moment. Thanks to @joeypoon for the help in getting the right artifacts committed. |
Building works great on OSX (dusted off my old MBP 2015). |
Change Summary
A few fields and mappings have been added in order to support the new Terminal Output feature coming out in 8.5
The ECS changes are currently merged to main, but since it won't go out till 8.5, I've added a subset of the changes here in endpoint-package.
Sample values
Release Target
8.5
Q/A
For mapping changes:
make
after making the schema changes, and committed all changes