Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terminal output] Fields coming in 8.5 added to custom_schemas/subsets #294

Merged
merged 11 commits into from
Sep 6, 2022

Conversation

mitodrummer
Copy link
Contributor

@mitodrummer mitodrummer commented Aug 31, 2022

Change Summary

A few fields and mappings have been added in order to support the new Terminal Output feature coming out in 8.5

The ECS changes are currently merged to main, but since it won't go out till 8.5, I've added a subset of the changes here in endpoint-package.

Sample values

{
  process: {
    tty: {
      rows: 24,
      columns: 80
    },
    io: {
      type: 'tty',
      text: "helloworld",
      total_bytes_captured: 1024,
      total_bytes_skipped: 0,
      bytes_skipped: [],
      max_bytes_per_process_exceeded: false
    }
}

Release Target

8.5

Q/A

For mapping changes:

  • I ran make after making the schema changes, and committed all changes

@mitodrummer mitodrummer requested a review from a team as a code owner August 31, 2022 22:12
@mitodrummer
Copy link
Contributor Author

Had this problem in my last PR, but for some reason i'm not getting all the generate artifacts, and so haven't been able to validate these changes work... hopefully CI will give some insights.

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 31, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-05T22:58:37.065+0000

  • Duration: 7 min 23 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mitodrummer
Copy link
Contributor Author

Yup, so for some reason, make or make -B is not producing the expected generated schemas.. I'm using ubuntu 22 with python3.10

Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to be losing some top-level definitions of the tty object here. the sub-fields under it (eg X.tty.Y seem to still be here, just the docs and description of the tty object, which is strange.

Not sure if that's intentional or we have some out-of-date ECS building happening

@mitodrummer
Copy link
Contributor Author

We seem to be losing some top-level definitions of the tty object here. the sub-fields under it (eg X.tty.Y seem to still be here, just the docs and description of the tty object, which is strange.

Not sure if that's intentional or we have some out-of-date ECS building happening

Yea that is strange, I wonder if the custom_schemas changes are some how overriding everything else under the tty object. I can try and include the rest of the fields for the tty object to see if that fixes it. Though, my local build issues are a blocker at the moment. Thanks to @joeypoon for the help in getting the right artifacts committed.

@mitodrummer
Copy link
Contributor Author

Building works great on OSX (dusted off my old MBP 2015).

@mitodrummer mitodrummer requested a review from pzl September 1, 2022 22:20
@mitodrummer mitodrummer merged commit 3cfcb5c into master Sep 6, 2022
@pzl pzl deleted the tty_io_additions branch November 22, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants