Rename process.Ext.session -> session_info and restore legacy keyword field
#318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
gabriellandau
force-pushed
the
rename-process-ext-session-8.6
branch
from
08e4fc0
to
e032aed
Compare
|
@kevinlog Ready for review. |
|
/test |
kevinlog
approved these changes
Nov 28, 2022
kevinlog
pushed a commit
that referenced
this pull request
Nov 28, 2022
kevinlog
added a commit
that referenced
this pull request
Nov 28, 2022
#320) Co-authored-by: Gabriel Landau <42078554+gabriellandau@users.noreply.github.com>
|
Package endpoint - 8.6.1 containing this change is available at https://epr.elastic.co/search?package=endpoint |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Rename
process.Ext.session->session_info. Restoresprocess.Ext.sessionas akeywordfield, reverting part of #309. @kevinlog raised a concern about potential backwards compatibility. I don't believe the field was ever used, but I'm opening this so we can be ready to merge it if we decide to do so.We don't necessarily want to merge this. It's still up for discussion.
Sample values
See adjustment to
package/endpoint/data_stream/process/sample_event.jsonRelease Target
8.6.0
Q/A
For mapping changes:
makeafter making the schema changes, and committed all changes