-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding persistence event #336
Conversation
@@ -0,0 +1,246 @@ | |||
--- | |||
name: file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is just a new subset of fields in file events and not a new data_stream, we don't need a new top level custom_subset for persistence
.
We should probably just have another section for Persistence
under the existing file.yml
file. Similar to this: https://github.com/elastic/endpoint-package/blob/main/custom_subsets/elastic_endpoint/file/file.yaml#L152
@@ -0,0 +1,1666 @@ | |||
- name: '@timestamp' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're not introducing a new data_stream, this shouldn't get created by make
. It's being made here because there is a new top level custom_subset for persistence
.
By addressing this comment: https://github.com/elastic/endpoint-package/pull/336/files#r1090819658 - it should clean this up with another make clean
and make all
b50389d
to
ce72709
Compare
Package endpoint - 8.7.0 containing this change is available at https://epr.elastic.co/search?package=endpoint |
Change Summary
Adding Persistence events mappings:
Sample values
Sample document:
Release Target
Q/A
For mapping changes:
make
after making the schema changes, and committed all changesmetadata
change, I also updated both transform destination schemas to matchFor Transform changes: