Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional process callstack custom_documentation fields #435

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

jdu2600
Copy link
Contributor

@jdu2600 jdu2600 commented Oct 3, 2023

Change Summary

Add missing process.parent.thread.Ext.call_stack fields to custom_documentation.
These optional fields have existed since 8.8.0

@jdu2600 jdu2600 added the documentation Improvements or additions to documentation label Oct 3, 2023
@jdu2600 jdu2600 requested a review from a team as a code owner October 3, 2023 08:39
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-03T08:39:47.730+0000

  • Duration: 7 min 53 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@gabriellandau
Copy link
Contributor

Thanks @jdu2600

@gabriellandau gabriellandau enabled auto-merge (squash) October 3, 2023 14:37
@gabriellandau gabriellandau changed the title additional process callstack fields additional process callstack custom_documentation fields Oct 3, 2023
@gabriellandau
Copy link
Contributor

@joeypoon I don't think this is PR is touching anything related to this. Do you know how to resolve this? https://buildkite.com/elastic/endpoint-package/builds/76#018af4af-0bad-4fa5-b452-b98fe7af6866/188-189

Traceback (most recent call last):
  File "/opt/buildkite-agent/builds/bk-agent-prod-gcp-1696322235768810428/elastic/endpoint-package/.buildkite/scripts/find_oldest_supported_version.py", line 262, in <module>
    main()
  File "/opt/buildkite-agent/builds/bk-agent-prod-gcp-1696322235768810428/elastic/endpoint-package/.buildkite/scripts/find_oldest_supported_version.py", line 129, in main
    run(cfg)
  File "/opt/buildkite-agent/builds/bk-agent-prod-gcp-1696322235768810428/elastic/endpoint-package/.buildkite/scripts/find_oldest_supported_version.py", line 119, in run
    kibana_version_condition = manifest_doc["conditions"]["kibana.version"]
KeyError: 'kibana.version'
🚨 Error: The command exited with status 1
user command error: exit status 1

@joeypoon
Copy link
Member

joeypoon commented Oct 3, 2023

@joeypoon I don't think this is PR is touching anything related to this. Do you know how to resolve this? buildkite.com/elastic/endpoint-package/builds/76#018af4af-0bad-4fa5-b452-b98fe7af6866/188-189

Traceback (most recent call last):
  File "/opt/buildkite-agent/builds/bk-agent-prod-gcp-1696322235768810428/elastic/endpoint-package/.buildkite/scripts/find_oldest_supported_version.py", line 262, in <module>
    main()
  File "/opt/buildkite-agent/builds/bk-agent-prod-gcp-1696322235768810428/elastic/endpoint-package/.buildkite/scripts/find_oldest_supported_version.py", line 129, in main
    run(cfg)
  File "/opt/buildkite-agent/builds/bk-agent-prod-gcp-1696322235768810428/elastic/endpoint-package/.buildkite/scripts/find_oldest_supported_version.py", line 119, in run
    kibana_version_condition = manifest_doc["conditions"]["kibana.version"]
KeyError: 'kibana.version'
🚨 Error: The command exited with status 1
user command error: exit status 1

pretty sure that's just transient from the recent version bump for release. we can ignore this right @pzl ?

@kevinlog
Copy link
Contributor

kevinlog commented Oct 3, 2023

yes, this is just buildkite related that is an in-progress migration

@gabriellandau gabriellandau merged commit b412bfe into main Oct 3, 2023
7 of 9 checks passed
@pzl
Copy link
Member

pzl commented Oct 3, 2023

Yes, we are still mid-process transitioning to Buildkite, so it is expected to fail until the CI migration is unblocked.

The ones marked required are the important ones, they are passing, so this is good (also any changes to the custom_documentation stuff is more or less instant-approve, merge at will. It is not shipped as part of the package itself (only things in package/endpoint get deployed to package stores)

@gabriellandau gabriellandau deleted the endpoint_process_callstack branch October 3, 2023 17:48
gabriellandau pushed a commit that referenced this pull request Oct 3, 2023
* add missing process.parent.thread.Ext.call_stack fields

* add generated file
@gabriellandau
Copy link
Contributor

Thanks @joeypoon @kevinlog. Cherry-picked backport PR is here: #437

gabriellandau added a commit that referenced this pull request Oct 3, 2023
* add missing process.parent.thread.Ext.call_stack fields

* add generated file

Co-authored-by: John U <53329154+jdu2600@users.noreply.github.com>
@pzl pzl removed the v8.10.3 label Nov 6, 2023
pzl pushed a commit that referenced this pull request Dec 11, 2023
* add missing process.parent.thread.Ext.call_stack fields

* add generated file
@elasticmachine
Copy link
Contributor

Package endpoint - 8.12.0 containing this change is available at https://epr.elastic.co/search?package=endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants