Skip to content

Commit

Permalink
[PR feedback] Fix fullscreen mode scroll overlay duplication
Browse files Browse the repository at this point in the history
- By converting the pagination border to a box-shadow and tweaking z-indices to better reflect overlapping behavior
  • Loading branch information
cee-chen committed Jan 27, 2022
1 parent f7a7eba commit 612ae0e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions src/components/datagrid/_data_grid.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
.euiDataGrid__pagination {
padding-bottom: $euiSizeXS;
background: $euiColorLightestShade;
border-top: $euiBorderThin;
box-shadow: $euiBorderWidthThin 0 0 $euiBorderWidthThin $euiBorderColor; // Use box-shadow instead of border-top to avoid duplicating the border-bottom on grid cells
}
}

Expand All @@ -29,13 +29,14 @@
max-width: 100%;
width: 100%;
overflow: hidden;
z-index: 2; // Sits above the pagination below it, but below the controls above it
z-index: 1; // Sits below the controls above it and pagination below it
position: relative;
background: $euiColorEmptyShade;
font-feature-settings: 'tnum' 1; // Tabular numbers
}

.euiDataGrid__pagination {
z-index: 2; // Sits above the content above it
padding-top: $euiSizeXS;
flex-grow: 0;
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/datagrid/controls/_data_grid_toolbar.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.euiDataGrid__controls {
background: $euiPageBackgroundColor;
position: relative;
z-index: 3; // Needs to sit above the content blow that sits below it
z-index: 2; // Needs to sit above the content below it
border: $euiBorderThin;
padding: $euiSizeXS $euiSizeXS $euiSizeXS 0;
display: flex;
Expand Down

0 comments on commit 612ae0e

Please sign in to comment.