Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow title, alt on EuiIcon #1917

Closed
chandlerprall opened this issue May 3, 2019 · 2 comments · Fixed by #2554
Closed

Allow title, alt on EuiIcon #1917

chandlerprall opened this issue May 3, 2019 · 2 comments · Fixed by #2554
Assignees
@miukimiu
Labels
accessibility bug

Comments

@chandlerprall
Copy link
Contributor

A couple components (EuiHeaderLogo, EuiStepNumber, and docs for EuiToolTip) pass the title prop to EuiIcon, which is invalid. Allow EuiIcon to accept this prop and update these components accordingly.
@chandlerprall chandlerprall mentioned this issue May 28, 2019
Merged
@thompsongl
Copy link
Contributor

Similarly, jsx-a11y linter brings up that the img tag used with custom icons should have an alt prop. We should handle this at the same time.

@thompsongl thompsongl changed the title Allow title on EuiIcon Allow title, alt on EuiIcon May 31, 2019
@thompsongl thompsongl mentioned this issue May 31, 2019
Merged
@thompsongl
Copy link
Contributor

#579 is relevant to this work, also

@miukimiu miukimiu self-assigned this Oct 22, 2019
@snide snide mentioned this issue Nov 13, 2019
Closed
19 tasks
@miukimiu miukimiu mentioned this issue Nov 21, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miukimiu miukimiu

Labels
accessibility bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

EuiIcon a11y miukimiu/eui
4 participants
@chandlerprall @cchaos @thompsongl @miukimiu