Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDatePicker] Support inline + showTimeSelectOnly on mobile #4218

Closed
smhutch opened this issue Nov 3, 2020 · 1 comment · Fixed by #4301
Closed

[EuiDatePicker] Support inline + showTimeSelectOnly on mobile #4218

smhutch opened this issue Nov 3, 2020 · 1 comment · Fixed by #4301

Comments

@smhutch
Copy link
Contributor

smhutch commented Nov 3, 2020

display: none is applied on mobile to the time picker within DatePicker.

Demo

Sandbox

Design on 768px wide screens

Image 2020-11-03 at 2 52 01 PM

Design on 767px wide screens

Image 2020-11-03 at 2 53 02 PM

Workaround

Currently I have a CSS override to work around this:

#my-component .react-datepicker__time-container {
  display: block !important;
}
@thompsongl thompsongl changed the title [DatePicker] Support inline + showTimeSelectOnly on mobile [EuiDatePicker] Support inline + showTimeSelectOnly on mobile Nov 3, 2020
@cchaos
Copy link
Contributor

cchaos commented Nov 5, 2020

I think we should just remove the media query on this one. Since the inputs aren't real inputs there's no way to add in a time selection on mobile. We can rethink how we want to handle mobile layout when we address the rewrite of this component. But for now lets just fix the problem.

@cchaos cchaos self-assigned this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants