Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSteps] Add more flexibility/customizability #4492

Closed
mdefazio opened this issue Feb 5, 2021 · 6 comments · Fixed by #5730
Closed

[EuiSteps] Add more flexibility/customizability #4492

mdefazio opened this issue Feb 5, 2021 · 6 comments · Fixed by #5730

Comments

@mdefazio
Copy link
Contributor

mdefazio commented Feb 5, 2021

In our recent refresh to Index Lifecycle Management, we have a need to present options in a vertical timeline-like format to indicate the life cycle of data. Our design includes a set of icons that tie together vertically with a line, beside a set of panels that house the various options for that step. I suppose semantically speaking, this is closer to EuiSteps, but visually we felt EuiComment got us closer to what we wanted.

So admittedly, I'm not sure which component this request should target. It seems EuiComment is closest. Below are the list of requirements/requests:

  1. Ability to have the icon self-centering beside the header portion of the comment block. We have adjusted the height and it seems the icon aligns to the top of the comment block
  2. Ability to choose the icon type (large, update,...) separate from the comment block styling (currently choosing update styles the corresponding block differently)
  3. Ability to customize the margin size between blocks. (Seems better to do it in the component as the line connecting the icons would likely need to include this when calculating the height).

Image reference (from elastic/kibana#90291):
image

Annotated version:
image

Again, perhaps it makes more sense to expand on the EuiSteps component to allow for these options as that is more aligned to our use case. And we keep EuiComment more strict to a comment/activity feed.


If we use the EuiSteps component (unsure if the above requests would still be valid or solve themselves):

  1. Ability to customize icon (and size perhaps?)
  2. Ability to pass a set of elements instead of just a string to the title area
  3. It seems combining the title and content into a wrapping panel might require some reworking of the rendered structure. So I'm open to tweaking the design to accommodate or finding a compromise if we feel this is the better component to use for our case.

And as a side note, the EuiComment component feels less like Amsterdam than other components (rather, the difference between v7 and Amsterdam is less noticeable—namely the use of borders around a panel/block).

image


Tagging for awareness: elastic/kibana#88671

@anuragxxd
Copy link
Contributor

I am working on this.

@cchaos
Copy link
Contributor

cchaos commented Feb 19, 2021

Hey @git-anurag-hub , thanks for the interest in this one, but it's going to need more design thought on how best to handle these requests. I'd recommend grabbing from our list of good-first-issues.

@anuragxxd
Copy link
Contributor

Okay np @cchaos

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@cchaos
Copy link
Contributor

cchaos commented Aug 18, 2021

I'll keep this one open, but it's a more long-term goal.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@cchaos cchaos changed the title Add more flexibility to the EuiCommentList (or EuiSteps) [EuiSteps] Add more flexibility/customizability Feb 15, 2022
@cchaos cchaos added this to To do in CSS in JS via automation Feb 15, 2022
@cchaos cchaos moved this from To do to To do during component conversions in CSS in JS Feb 15, 2022
@miukimiu miukimiu mentioned this issue Mar 21, 2022
11 tasks
Component Refactors automation moved this from Consider to Closed Apr 13, 2022
CSS in JS automation moved this from To do during component conversions to Done Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants