Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiLink should support both href and onClick simultaneously #553

Closed
chrisdavies opened this issue Mar 21, 2018 · 0 comments
Closed

EuiLink should support both href and onClick simultaneously #553

chrisdavies opened this issue Mar 21, 2018 · 0 comments

Comments

@chrisdavies
Copy link
Contributor

Currently, EuiLink disallows both href and onClick to be specified. If there is an onClick, EuiLink always renders as an HTML button. But there are scenarios where it is desirable to have an actual a element with an href and onClick, for example, if you wanted to show a confirmation dialog when the user is navigating to an external link.

My proposal is to render a button if href is not provided or is blank, and to otherwise render an a tag.

chrisdavies added a commit to chrisdavies/eui that referenced this issue Mar 21, 2018
chrisdavies added a commit to chrisdavies/eui that referenced this issue Mar 26, 2018
chrisdavies added a commit that referenced this issue Mar 26, 2018
Update link, button, card, etc to support both href and onClick.

Fixes #553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants