Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox fixes #1183

Merged
merged 2 commits into from Sep 11, 2018
Merged

Combobox fixes #1183

merged 2 commits into from Sep 11, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Sep 11, 2018

Fixes #1168

  • pass onClick and onClickAriaLabel properly
  • Fix plain text vertical alignment in IE

Before
screen shot 2018-09-11 at 12 53 16 pm

After
screen shot 2018-09-11 at 12 59 57 pm

Combobox fixes
6b80588 
- pass `onClick` and `onClickAriaLabel` properly
- Fix plain text vertical alignment in IE
chandlerprall
chandlerprall approved these changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review

@cchaos cchaos merged commit 1ae816b into elastic:master Sep 11, 2018
@cchaos cchaos deleted the fix-single-selection branch September 11, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cchaos @chandlerprall