Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE11 doesn't support document.contains() #1190

Merged
merged 2 commits into from Sep 13, 2018
Merged

IE11 doesn't support document.contains() #1190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3445f0d
IE11 doesn't support contains()
snide Sep 13, 2018
0d4b2b2
cl
snide Sep 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
@@ -1,6 +1,8 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Fixed issue with unselected tabs and aria-controls attribute in EuiTabbedContent
**Bug fixes**

- Fixed an issue in `EuiTooltip` because IE1 didn't support `document.contains()` ([#1190](https://github.com/elastic/eui/pull/1190))

## [`4.0.0`](https://github.com/elastic/eui/tree/v4.0.0)

Expand Down
2 changes: 1 addition & 1 deletion src/components/tool_tip/tool_tip.js
View file
Open in desktop
Expand Up @@ -72,7 +72,7 @@ export class EuiToolTip extends Component {
// when the tooltip is visible, this checks if the anchor is still part of document
// this fixes when the react root is removed from the dom without unmounting
// https://github.com/elastic/eui/issues/1105
if (document.contains(this.anchor) === false) {
if (document.body.contains(this.anchor) === false) {
// the anchor is no longer part of `document`
this.hideToolTip();
} else {
Expand Down