Add display, descriptionWidth, textWrap and isInvalid props to EuiExpression #3467
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,208 @@ | ||||||||
| import React, { useState } from 'react'; | ||||||||
|
|
||||||||
| import { | ||||||||
| EuiPopoverTitle, | ||||||||
| EuiPopover, | ||||||||
| EuiSelect, | ||||||||
| EuiComboBox, | ||||||||
| EuiExpression, | ||||||||
| EuiTitle, | ||||||||
| EuiSpacer, | ||||||||
| } from '../../../../src/components'; | ||||||||
|
|
||||||||
| export default () => { | ||||||||
| const [example1, setExample1] = useState({ | ||||||||
| isOpen: false, | ||||||||
| value: ( | ||||||||
| <div> | ||||||||
| <p>.kibana_task_manager,</p> | ||||||||
| <p>kibana_sample_data_ecommerce</p> | ||||||||
| </div> | ||||||||
| ), | ||||||||
| }); | ||||||||
|
|
||||||||
| const [example2, setExample2] = useState({ | ||||||||
| isOpen: false, | ||||||||
| value: 'count()', | ||||||||
| }); | ||||||||
|
|
||||||||
| const options = [ | ||||||||
| { | ||||||||
| label: '.kibana_task_manager', | ||||||||
| }, | ||||||||
| { | ||||||||
| label: 'kibana_sample_data_ecommerce', | ||||||||
| }, | ||||||||
| { | ||||||||
| label: '.kibana-event-log-8.0.0-000001', | ||||||||
| }, | ||||||||
| { | ||||||||
| label: 'kibana_sample_data_flights', | ||||||||
| }, | ||||||||
| { | ||||||||
| label: '.kibana-event-log-8.0.0', | ||||||||
| }, | ||||||||
| ]; | ||||||||
|
|
||||||||
| const [selectedOptions, setSelected] = useState([options[0], options[1]]); | ||||||||
|
|
||||||||
| const openExample1 = () => { | ||||||||
| setExample1({ | ||||||||
| ...example1, | ||||||||
| isOpen: !example1.isOpen, | ||||||||
| }); | ||||||||
| setExample2({ | ||||||||
| ...example2, | ||||||||
| }); | ||||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||||
| }; | ||||||||
|
|
||||||||
| const closeExample1 = () => { | ||||||||
| setExample1({ | ||||||||
| ...example1, | ||||||||
| isOpen: false, | ||||||||
| }); | ||||||||
| }; | ||||||||
|
|
||||||||
| const openExample2 = () => { | ||||||||
| setExample1({ | ||||||||
| ...example1, | ||||||||
| }); | ||||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||||
| setExample2({ | ||||||||
| ...example2, | ||||||||
| isOpen: !example2.isOpen, | ||||||||
| }); | ||||||||
| }; | ||||||||
|
|
||||||||
| const closeExample2 = () => { | ||||||||
| setExample2({ | ||||||||
| ...example2, | ||||||||
| isOpen: false, | ||||||||
| }); | ||||||||
| }; | ||||||||
|
|
||||||||
| const changeExample2 = e => { | ||||||||
| setExample2({ | ||||||||
| value: e.target.value, | ||||||||
| isOpen: false, | ||||||||
| }); | ||||||||
| }; | ||||||||
|
|
||||||||
| const onChange = selectedOptions => { | ||||||||
| setSelected(selectedOptions); | ||||||||
| const indices = selectedOptions.map((s, index) => { | ||||||||
| return ( | ||||||||
| <p key={index}> | ||||||||
| {s.label} | ||||||||
| {index < selectedOptions.length - 1 ? ',' : null} | ||||||||
| </p> | ||||||||
| ); | ||||||||
| }); | ||||||||
| setExample1({ | ||||||||
| ...example1, | ||||||||
| value: indices, | ||||||||
| }); | ||||||||
| }; | ||||||||
|
|
||||||||
| const renderPopover1 = () => ( | ||||||||
| <div style={{ width: 300 }}> | ||||||||
| <EuiPopoverTitle>INDICES</EuiPopoverTitle> | ||||||||
| <EuiComboBox | ||||||||
| placeholder="Select one or more indices" | ||||||||
| options={options} | ||||||||
| selectedOptions={selectedOptions} | ||||||||
| onChange={onChange} | ||||||||
| isClearable={true} | ||||||||
| data-test-subj="demoComboBox" | ||||||||
| /> | ||||||||
| </div> | ||||||||
| ); | ||||||||
|
|
||||||||
| const renderPopover2 = () => ( | ||||||||
| <div style={{ width: 150 }}> | ||||||||
| <EuiPopoverTitle>WHEN</EuiPopoverTitle> | ||||||||
| <EuiSelect | ||||||||
| compressed | ||||||||
| value={example2.value} | ||||||||
| onChange={changeExample2} | ||||||||
| options={[ | ||||||||
| { | ||||||||
| value: 'count()', | ||||||||
| text: 'count()', | ||||||||
| }, | ||||||||
| { | ||||||||
| value: 'sum()', | ||||||||
| text: 'sum()', | ||||||||
| }, | ||||||||
| { | ||||||||
| value: 'min()', | ||||||||
| text: 'min()', | ||||||||
| }, | ||||||||
| { value: 'max()', text: 'max()' }, | ||||||||
| ]} | ||||||||
| /> | ||||||||
| </div> | ||||||||
| ); | ||||||||
|
|
||||||||
| return ( | ||||||||
| <div style={{ maxWidth: 500 }}> | ||||||||
| <EuiPopover | ||||||||
| id="columnsPopover1" | ||||||||
| button={ | ||||||||
| <EuiExpression | ||||||||
| description="indices" | ||||||||
| display="columns" | ||||||||
| value={example1.value} | ||||||||
| isInvalid={ | ||||||||
| selectedOptions && selectedOptions.length > 0 ? false : true | ||||||||
| } | ||||||||
| isActive={example1.isOpen} | ||||||||
| onClick={openExample1} | ||||||||
| /> | ||||||||
| } | ||||||||
| isOpen={example1.isOpen} | ||||||||
| closePopover={closeExample1} | ||||||||
| ownFocus | ||||||||
| display="block" | ||||||||
| panelPaddingSize="s" | ||||||||
| anchorPosition="downLeft"> | ||||||||
| {renderPopover1()} | ||||||||
| </EuiPopover> | ||||||||
|
|
||||||||
| <EuiPopover | ||||||||
| id="columnsPopover2" | ||||||||
| panelPaddingSize="s" | ||||||||
| button={ | ||||||||
| <EuiExpression | ||||||||
| description="when" | ||||||||
| display="columns" | ||||||||
| value={example2.value} | ||||||||
| isActive={example2.isOpen} | ||||||||
| onClick={openExample2} | ||||||||
| /> | ||||||||
| } | ||||||||
| isOpen={example2.isOpen} | ||||||||
| closePopover={closeExample2} | ||||||||
| ownFocus | ||||||||
| display="block" | ||||||||
| anchorPosition="downLeft"> | ||||||||
| {renderPopover2()} | ||||||||
| </EuiPopover> | ||||||||
| <EuiExpression | ||||||||
| display="columns" | ||||||||
| description="Except" | ||||||||
| value="kibana_sample_data_ky_counties" | ||||||||
| /> | ||||||||
| <EuiSpacer /> | ||||||||
| <EuiTitle size="xxs"> | ||||||||
| <h3>Description width at 50px</h3> | ||||||||
| </EuiTitle> | ||||||||
| <EuiExpression | ||||||||
| description="join" | ||||||||
| display="columns" | ||||||||
| descriptionWidth={50} | ||||||||
| value="kibana_sample_data_ky_avl" | ||||||||
| onClick={() => {}} | ||||||||
| /> | ||||||||
| </div> | ||||||||
| ); | ||||||||
| }; | ||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import React from 'react'; | ||
|
|
||
| import { EuiExpression, EuiSpacer } from '../../../../src/components'; | ||
|
|
||
| export default () => ( | ||
| <div> | ||
| <EuiExpression | ||
| onClick={() => {}} | ||
| description="sort by" | ||
| value="count" | ||
| isInvalid | ||
| /> | ||
| <EuiSpacer /> | ||
| <div style={{ maxWidth: 220 }}> | ||
| <EuiExpression | ||
| description="email" | ||
| display="columns" | ||
| isInvalid | ||
| value="example@mail." | ||
| onClick={() => {}} | ||
| /> | ||
| </div> | ||
| </div> | ||
| ); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need this
div, but if you do, it gets removed if you change the selected options, so you need to add it to theonChangefunction as well. You can simply change it to a fragment<></>