[Docs] IE11 & Playground #3776
Merged
[Docs] IE11 & Playground #3776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3776/ |
|
This error after transpiling occurs because Es6 template literals aren't converted. |
|
Also, some other errors occur |
|
Thanks. No errors were showing in my VM |
I have added a plugin to fix the string template problem also , included |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3776/ |
|
This is working locally but still has errors at https://eui.elastic.co/pr_3776/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3776/ |
|
🎉 |
chandlerprall
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Transpiles the untranspiled libraries associated with
react-view. This is not an ideal scenario and we should roll back these changes as our outlook on IE11 support changes.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] A changelog entry exists and is marked appropriately