Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] EuiCodeEditor - Removed examples and added deprecation notice #4683

Merged
merged 1 commit into from
Apr 2, 2021
Merged

[Docs] EuiCodeEditor - Removed examples and added deprecation notice #4683

merged 1 commit into from
Apr 2, 2021

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Apr 2, 2021

I completely remove all docs examples and props tables as we really don't want users to use it.

Screen Shot 2021-04-02 at 10 48 24 AM

Checklist

@cchaos cchaos added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Apr 2, 2021
@cchaos cchaos mentioned this pull request Apr 2, 2021
Open
33 tasks
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4683/

chandlerprall
chandlerprall approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@cchaos cchaos merged commit f7e07ac into elastic:master Apr 2, 2021
@cjcenizal cjcenizal mentioned this pull request May 10, 2021
Closed
@cchaos cchaos deleted the docs/code-editor branch May 11, 2021 19:45
@alisonelizabeth alisonelizabeth mentioned this pull request May 14, 2021
Merged
@tilman
Copy link

tilman commented May 21, 2021

The react-ace module makes it impossible to use the whole library in an SSR environment. Is there already a date planned when this module should be removed completely?

@dukesx
Copy link

dukesx commented Jul 27, 2021

The react-ace module makes it impossible to use the whole library in an SSR environment. Is there already a date planned when this module should be removed completely?

i have the same question.

@thompsongl
Copy link
Contributor

@dukesx Perfect timing. I plan on opening a PR to remove EuiCodeEditor (and react-ace) today.

@dukesx
Copy link

dukesx commented Jul 27, 2021

@dukesx Perfect timing. I plan on opening a PR to remove EuiCodeEditor (and react-ace) today.

hurray ! can't wait

@thompsongl thompsongl mentioned this pull request Oct 26, 2021
Merged
5 tasks
@asteriscos asteriscos mentioned this pull request Nov 7, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cchaos @kibanamachine @tilman @dukesx @thompsongl @chandlerprall