Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated EuiForm examples #4734

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Updated EuiForm examples #4734

merged 2 commits into from
Apr 21, 2021

Conversation

hetanthakkar
Copy link
Contributor

Summary

Fixed #4711: Updated examples to used EuiForms to use component="form" as a prop

Checklist

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@hetanthakkar
Copy link
Contributor Author

@myasonik @cchaos @thompsongl Could you please review!?

@hetanthakkar
Copy link
Contributor Author

Btw, I am about to finish making the code snippet extension for Eui components! Do you think it's a good idea!? If yes I can make a PR for the same tomorrow

@cchaos
Copy link
Contributor

cchaos commented Apr 19, 2021

Btw, I am about to finish making the code snippet extension for Eui components!

Oh! What is that?

@hetanthakkar
Copy link
Contributor Author

@cchaos An extension that is similar to react code snippets where if you just type in say for example !euiAccordian, it will autofill a minimal code (the code present in snippet section of the component). Using this will help the developers as they wont have to visit the docs frequently when they want to use a component! I think it will surely help to speed up the developers while using the eui components

@cchaos
Copy link
Contributor

cchaos commented Apr 19, 2021

Oh interesting! Without bogging down this specific PR, I've transferred your comment to a "Show and tell" type of discussion. #4735 Where we'd love to see some more of it in action if you can.

@cchaos
Copy link
Contributor

cchaos commented Apr 19, 2021

Before I run CI on this PR, can you clean up the changed files. It looks like there are some bad test updates and the changelog is from a different PR. This one won't need a changelog because it should only address docs.

@hetanthakkar
Copy link
Contributor Author

@cchaos Sure! I am on it

@hetanthakkar
Copy link
Contributor Author

@cchaos Please view!

@hetanthakkar
Copy link
Contributor Author

@cchaos I have also uploaded a small basic screencast for that extension. Do check it out!

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM! Would you also mind updating the snippets too? It was mentioned yesterday someone needed it in the modal form snippet.

@hetanthakkar
Copy link
Contributor Author

@cchaos I've updated every docs that used EuiForm. I don't get you

@hetanthakkar
Copy link
Contributor Author

@cchaos are there any other examples of EuiForm left out that I forgot to modify

@cchaos
Copy link
Contributor

cchaos commented Apr 20, 2021

In the _example.js files, there are code snippets. I assume the same ones you're using to add to your VS Code extension. That could use this same prop added too. Like at this line:

<EuiForm id={formId}><!-- Modal body --></EuiForm>

@hetanthakkar
Copy link
Contributor Author

@cchaos Can you please review

@cchaos
Copy link
Contributor

cchaos commented Apr 20, 2021

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4734/

@hetanthakkar
Copy link
Contributor Author

@cchaos You can merge this. btw where should I submit that vs code extension repo!?

@cchaos cchaos merged commit f2764e3 into elastic:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Form Layouts] Align examples to best practices
3 participants